Skip to content

Conversation

@febo
Copy link
Collaborator

@febo febo commented Oct 9, 2025

Problem

Now that pinocchio includes dependencies to SDK types, the crate details on the README.md and lib.rs are not accurate.

Solution

Update the crate details.

@febo febo force-pushed the febo/crate-details branch from eae2838 to 830639f Compare October 9, 2025 11:55
@febo febo force-pushed the febo/crate-details branch from 830639f to ced5cb4 Compare October 13, 2025 13:38
@febo febo force-pushed the febo/crate-details branch from ced5cb4 to a044485 Compare November 25, 2025 18:32
@febo febo force-pushed the febo/crate-details branch 4 times, most recently from 6517558 to 26c45f5 Compare November 25, 2025 22:57
@febo febo force-pushed the febo/crate-details branch 4 times, most recently from ebb2e0d to 4f603aa Compare November 26, 2025 00:13
@febo febo marked this pull request as ready for review November 26, 2025 10:09
@febo febo force-pushed the febo/crate-details branch from 607fd49 to 2c775db Compare November 26, 2025 11:40
rustopian
rustopian previously approved these changes Nov 26, 2025
Copy link
Contributor

@rustopian rustopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. One typo hanging around in a heading.

README.md Outdated
pinocchio = { version = "0.10.0", features = ["cpi"] }
```

## Advance entrypoint configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Advance entrypoint configuration
## Advanced entrypoint configuration

joncinque
joncinque previously approved these changes Nov 26, 2025
Copy link
Collaborator

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with Pete's comment resolved

Base automatically changed from febo/remove-log to main December 3, 2025 13:52
@febo febo dismissed stale reviews from joncinque and rustopian December 3, 2025 13:52

The base branch was changed.

@febo febo force-pushed the febo/crate-details branch from 087e32b to ec4b7c5 Compare December 3, 2025 14:02
@febo febo requested review from joncinque and rustopian December 3, 2025 14:09
@febo febo merged commit 4fcff84 into main Dec 3, 2025
8 checks passed
@febo febo deleted the febo/crate-details branch December 3, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants