feat: add s3 backends #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This is a cool contribution, would you mind feature gating this so we don't have to always pull in the s3 crates etc for people who don't need it? Also CI might need to be adjusted so lints etc run with all-features and without all-features if it hasn't been already, I haven't looked in a while Thank you! |
Contributor
Author
|
Went ahead and updated the workflow to build standard features and Also merged in upstream changes! |
Collaborator
|
sorry one more set of upstream changes, now 0.2.0 is released so should have less problems! |
# Conflicts: # Cargo.lock # jetstreamer-firehose/src/index.rs
Contributor
Author
|
Should be g2g now, we've been running this internally for a couple weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced an optional S3 transport for firehose archives so deployments can stream CARs and compact indexes from private buckets instead of the public Old Faithful mirror.