Skip to content

Conversation

@brooksprumo
Copy link

Problem

Bank::store_account_and_update_capitalization() does not update accounts_data_size correctly if the new account has zero lamports (i.e. is being closed).

Summary of Changes

Fix it.

@brooksprumo brooksprumo self-assigned this Dec 4, 2025
@brooksprumo brooksprumo marked this pull request as ready for review December 4, 2025 23:02
@brooksprumo
Copy link
Author

@jstarry - requesting your review because I feel like you're someone who knows about this code.
@igor56D - requesting your review as someone looking into the accounts data size stuff.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.5%. Comparing base (7fa607c) to head (739aac8).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9418   +/-   ##
=======================================
  Coverage    82.5%    82.5%           
=======================================
  Files         895      895           
  Lines      322472   322500   +28     
=======================================
+ Hits       266223   266270   +47     
+ Misses      56249    56230   -19     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's not used currently but can we fix fn replace_program_account too?

@brooksprumo
Copy link
Author

Looks like it's not used currently but can we fix fn replace_program_account too?

Already done! #9396

@brooksprumo brooksprumo requested a review from jstarry December 5, 2025 13:00
@brooksprumo brooksprumo added this pull request to the merge queue Dec 5, 2025
Merged via the queue into anza-xyz:master with commit cc451cd Dec 5, 2025
47 checks passed
@brooksprumo brooksprumo deleted the accounts-data-size/store branch December 5, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants