-
Notifications
You must be signed in to change notification settings - Fork 841
ensure bricked gossip control account is offcurve #8300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure bricked gossip control account is offcurve #8300
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8300 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 836 836
Lines 367021 367026 +5
=========================================
- Hits 305577 305520 -57
- Misses 61444 61506 +62 🚀 New features to boost your workflow:
|
alexpyattaev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abundance of caution is nice
t-nelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is another situation where it's really more ideal to revert and commit together. please be more careful and forward thinking in the future
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
ensure bricked gossip control account is off curve (cherry picked from commit 75ee010)
ensure bricked gossip control account is off curve (cherry picked from commit 75ee010)
ensure bricked gossip control account is off curve (cherry picked from commit 75ee010)
ensure bricked gossip control account is off curve (cherry picked from commit 75ee010)
…8300) (#8311) * Gossip: brick gossip weight control key (#8256) brick gossip weight control key (cherry picked from commit 0e918ad) * ensure bricked gossip control account is offcurve (#8300) ensure bricked gossip control account is off curve (cherry picked from commit 75ee010) --------- Co-authored-by: Greg Cusack <[email protected]>
Problem
need test to ensure gossip control account is offcurve
Summary of Changes
add test