Skip to content

Conversation

@gregcusack
Copy link

@gregcusack gregcusack commented Oct 1, 2025

Problem

need test to ensure gossip control account is offcurve

Summary of Changes

add test

@gregcusack gregcusack requested a review from a team as a code owner October 1, 2025 19:48
@gregcusack gregcusack changed the title ensure bricked gossip control account is off curve ensure bricked gossip control account is offcurve Oct 1, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (9b5bd84) to head (7a43efa).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #8300     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         836      836             
  Lines      367021   367026      +5     
=========================================
- Hits       305577   305520     -57     
- Misses      61444    61506     +62     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abundance of caution is nice

Copy link

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is another situation where it's really more ideal to revert and commit together. please be more careful and forward thinking in the future

@gregcusack gregcusack merged commit 75ee010 into anza-xyz:master Oct 2, 2025
43 checks passed
@gregcusack gregcusack added the v3.0 Backport to v3.0 branch label Oct 2, 2025
@mergify
Copy link

mergify bot commented Oct 2, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Oct 2, 2025
ensure bricked gossip control account is off curve

(cherry picked from commit 75ee010)
gregcusack added a commit that referenced this pull request Oct 8, 2025
ensure bricked gossip control account is off curve

(cherry picked from commit 75ee010)
gregcusack added a commit that referenced this pull request Oct 8, 2025
ensure bricked gossip control account is off curve

(cherry picked from commit 75ee010)
gregcusack added a commit that referenced this pull request Oct 8, 2025
ensure bricked gossip control account is off curve

(cherry picked from commit 75ee010)
gregcusack added a commit that referenced this pull request Oct 8, 2025
…8300) (#8311)

* Gossip: brick gossip weight control key (#8256)

brick gossip weight control key

(cherry picked from commit 0e918ad)

* ensure bricked gossip control account is offcurve (#8300)

ensure bricked gossip control account is off curve

(cherry picked from commit 75ee010)

---------

Co-authored-by: Greg Cusack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3.0 Backport to v3.0 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants