refactor: static meta compute budget details

[jstarry]

Problem

StaticMeta::compute_budget_limits is the only trait method on StaticMeta which is not a simple getter function. In fact, it's actually a fairly expensive trait method given that it has to do extra sanitization and computation for the transaction's default compute limit. This design limits the flexibility of the sanitize_and_convert_to_compute_budget_limits method (e.g. it's not possible to change it to accept an iterator of instructions for computing the default compute unit limit).

Summary of Changes

• Replaced StaticMeta::compute_budget_limits with StaticMeta::compute_budget_instruction_details forcing the caller to explicitly sanitize the result if needed.
• Increased visibility of ComputeBudgetInstructionDetails to pub

Fixes #

[apfitzge]

I personally like this interface more. There are a few places where we do not need the compute budget limits in full; just the CU price/limit. which we could refactor visibility on.

Specifically for re-iterating instructions, I think we should avoid that if we can achieve the same outcome with a few cached u16s.

Please let @tao-stones review, since he has mainly designed this interface

[tao-stones]

Exposes ComputeBudgetInstructionDetails does provides flexibility, tho I am not fully convinced that *_details to be exposed outside of crate. Totally open to change crate public APIs, but keep details internal gives RuntimeTransaction crate options to optimize without impact on callsite, for example, combining signature_details with compute_budget_details to instruction_details. Just want to raise it to hear your guys opinions about what should be considered as internal data.

[jstarry]

I personally see the runtime tx crate as an internal crate anyways so I'm not concerned with what's publicly exposed. But in any case, ComputeBudgetInstructionDetails is a direct representation of the requested compute budget limits from a transaction so I think it makes a lot of sense to have this info be accessible in the static meta interface.

[tao-stones]

Can't find strong reason to not make it public, given the understanding RuntimeTransaction is a internal crate. (tho not clear how to enforce it). Small nit to potentially reduce number of files followup PR touches.

[tao-stones]

nit: if can add _feature_set: &FeatureSet to sanitize_and_convert_to_compute_budget_limits() as placeholder parameter, next PRs that's going to use feature_set won't have to touch these files again.

[jstarry]

Yeah I considered that but it just felt strange to modify that function when it wasn't related to the purpose of the PR