bug: passing a wrong theme now causes 500 Internal Error

[mikyll]

Describe the bug

When passing a theme that does not exist in query params (theme=...), I get the following error:

500: INTERNAL_SERVER_ERROR
Code: FUNCTION_INVOCATION_FAILED
ID: fra1::hrdcg-1762421377288-2993a3767f96

Expected behavior

I'd like to have the default theme as a fallback.

Screenshots / Live demo link

https://github-readme-stats.vercel.app/api?username=mikyll&show_icons=not&theme=foobar

Additional context

I noticed this some day ago, so I think this bug was mistakenly introduced with most recent commits

[iemafzalhassan]

Hey @mikyll 👋🏻

would love to work on this issue. Kindly assign it to me!

[iemafzalhassan]

Hello @anuraghazra 👋🏼

can you please review the PR.

[mikyll]

Hi @iemafzalhassan

I'm not a maintainer, so I cannot assign the issue nor review your PR 😅

[iemafzalhassan]

Oops I thought you're maintaining this project. sorry

[mikyll]

@iemafzalhassan I had a quick look at your PR out of curiosity...

You made changes in a branch that is 394 commits behind the main branch 😕

Moreover, the file where you made the fix src/common/utils.js, is not even present anymore on the main branch, since it was renamed to src/common/render.js with this commit: c43fd65.

[Franklyn-R-Silva]

I thought I was the only one with this bug, but I guess it's everyone!

[JF-2121]

Yes Sorry Reopened a Ticket just a couple hours ago the issue still persists :/

[mikyll]

@JF-2121 the issue you opened (#4661) is related to Vercel deployment, this one is related to application logic.

Currently theme query parameter doesn't have a default fallback when the theme specified with query parameters doesn't exist.