fix: hws sg add rule info

[Lyc-heng]

Thank you for your contribution to CloudRec!

What About:

• Server (java)
• Collector (go)
• Rule (opa)

Description:

Huawei cloud security group resource add security group rule information

[gemini-code-assist]

Summary of Changes

Hello @Lyc-heng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the Huawei Cloud security group data collection within the CloudRec system. It modifies the existing collector to not only retrieve basic security group information but also to fetch and store the associated security group rules. This enhancement provides a more complete and granular view of security configurations, which is crucial for comprehensive security analysis and compliance.

Highlights

• Enhanced Security Group Data Collection: The Huawei Cloud security group collector now gathers detailed security group rule information, providing a more comprehensive view of network access controls.
• Updated Data Structure: The SecurityGroupDetail struct has been extended to include the region and a new field, SecurityGroupDetail, which holds the comprehensive security group information including its rules.
• New Helper Function for Rule Retrieval: A new function, getSecurityGroupRules, was introduced to specifically fetch detailed security group information, including all associated rules, by utilizing the ShowSecurityGroup API.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the functionality to fetch security group rule information for Huawei Cloud security groups. The overall approach is correct, but I've identified a significant performance bottleneck due to sequential API calls being made within a loop. I've provided a suggestion to refactor this using concurrency to improve performance. Additionally, I've suggested a minor improvement to a log message to enhance debuggability.

[gemini-code-assist]

The current implementation fetches security group details sequentially for each security group within this loop. This will result in poor performance, especially when dealing with a large number of security groups (a classic N+1 query problem). To improve efficiency, these API calls should be performed concurrently.

I suggest using goroutines to parallelize the fetching of security group details. To prevent overwhelming the API endpoint, it's also a good practice to use a semaphore to limit the number of concurrent requests.

Note: You will need to add import "sync" to the file for this suggestion to work.

        var wg sync.WaitGroup
		// Using a semaphore to limit concurrency to avoid overwhelming the API endpoint.
		// The limit of 10 is an example and might need tuning based on API rate limits.
		sem := make(chan struct{}, 10)

		for _, securityGroup := range *response.SecurityGroups {
			wg.Add(1)
			go func(sg vpcModel.SecurityGroup) {
				defer wg.Done()
				sem <- struct{}{}        // Acquire a token
				defer func() { <-sem }() // Release the token

				res <- &SecurityGroupDetail{
					Region:              services.Region,
					SecurityGroup:       sg,
					SecurityGroupDetail: getSecurityGroupRules(ctx, sg, cli),
				}
			}(securityGroup)
		}
		wg.Wait()

[gemini-code-assist]

The log message "get SecurityGroup error" is a bit generic. For better traceability and debugging, it would be helpful to include the ID of the security group for which the operation failed.

        log.CtxLogger(ctx).Warn("failed to get details for security group", zap.String("security_group_id", securityGroup.Id), zap.Error(err))