Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(chips): don't throw when chip models are recursive, complex objects #11535

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Dec 5, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

If the model objects passed to md-chips include recursive structures (i.e. they include something like {value: 'Orange', parent: chipList}, then parsing them for announcements or displaying them in aria-labels throws an exception.

Issue Number:
N/A

What is the new behavior?

  • improve basic demo and md-chip-remove directive docs
  • no longer parse JSON object
    in order to try to provide some useful identifier in messages

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- improve basic demo and md-chip-remove directive docs
- no longer parse JSON object
  in order to try to provide some useful identifier in messages
@Splaktar Splaktar added type: bug a11y This issue is related to accessibility P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels Dec 5, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Dec 5, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 5, 2018
@mmalerba mmalerba added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer labels Dec 5, 2018
@mmalerba mmalerba merged commit b89beee into master Dec 5, 2018
@Splaktar Splaktar deleted the chips-supportRecursiveObjects branch December 5, 2018 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants