Skip to content

fix(tab-link): preventDefault action when disabled tab link is clicked. #9357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jelbourn merged 1 commit into from
Jan 23, 2018
Merged

fix(tab-link): preventDefault action when disabled tab link is clicked. #9357

jelbourn merged 1 commit into from
Jan 23, 2018

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Jan 12, 2018 •
edited
Loading

Fixes #8880

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 12, 2018
devversion
devversion approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib/tabs/tab-nav-bar/tab-nav-bar.spec.ts Outdated
it('should prevent default action for clicks if links are disabled', () => {
const tabLinkElement = fixture.debugElement.query(By.css('a')).nativeElement;

const mouseEvent = new MouseEvent('click');
Copy link
Member

@devversion devversion Jan 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use createMouseEvent('click') instead? This uses a more compatible (e.g. IE) logic for initializing the event.

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jan 17, 2018
@jelbourn jelbourn merged commit 8de5e83 into angular:master Jan 23, 2018
@josephperrott josephperrott mentioned this pull request Jan 24, 2018
Closed
@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Jan 29, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 29, 2018
@josephperrott @jelbourn
fix(tab-link): preventDefault action when disabled tab link is clicke…
0b5806b 
…d. (angular#9357)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
@josephperrott josephperrott deleted the tab-link branch March 20, 2020 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mat-tab-link component should be disabled if disabled is set

4 participants

@josephperrott @devversion @jelbourn @googlebot