Fix null issue in url youtube url when running a playlist with no vid… #31403
Conversation
…eoId When playing a playlist via playerVars.list = [playlistId] we dont have a videoId available yet. Plus we don't need one, Youtube will start at the first video of the playlist by default. By injecting an undefined videoId in the YT Player constructur, we end up with null value in the iframe url (`ps://www.youtube.com/embed/null?cc_load_policy=1&enablejsapi=1&controls=1&showinfo=0&rel=0&listType=playlist&list=PLxf07yK_HAvdwhW-L0X3uP5aMe6eEt50v`) which is causing an Invalid Video Id error for consumers.
mattiLeBlanc
requested review from
wagnermaciel and
ok7sai
and removed request for
a team
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I have just signed the CLA |
src/youtube-player/youtube-player.ts
Outdated
| @@ -587,17 +587,21 @@ export class YouTubePlayer implements AfterViewInit, OnChanges, OnDestroy { | |||
|
|
|||
| // Important! We need to create the Player object outside of the `NgZone`, because it kicks | |||
| // off a 250ms setInterval which will continually trigger change detection if we don't. | |||
| const params: any = { | |||
There was a problem hiding this comment.
This can be typed as YT.PlayerOptions, rather than any.
apply YT.PlayerOptions to params
fix formatting
fix unit test
|
@crisbeto let me know if it is alright now. |
Yeah, I am doing it inline so I can't format it. I haven't downloaded the full repo to my mac, I was a bit lazy. For the linter I ma have to do that. |
Fix formatting
|
@crisbeto Formatting should now be resolved. My comments went out of the boundary and some other comments also just crossed over so I corrected that. |
crisbeto
added
action: merge
|
The changes were merged into the following branches: main, 20.0.x |
…ideoId (#31403) * Fix null issue in url youtube url when running a playlist with no videoId When playing a playlist via playerVars.list = [playlistId] we dont have a videoId available yet. Plus we don't need one, Youtube will start at the first video of the playlist by default. By injecting an undefined videoId in the YT Player constructur, we end up with null value in the iframe url (`ps://www.youtube.com/embed/null?cc_load_policy=1&enablejsapi=1&controls=1&showinfo=0&rel=0&listType=playlist&list=PLxf07yK_HAvdwhW-L0X3uP5aMe6eEt50v`) which is causing an Invalid Video Id error for consumers. * Update youtube-player.ts apply YT.PlayerOptions to params * Update youtube-player.ts fix formatting * Update youtube-player.spec.ts fix unit test * Update youtube-player.ts Fix formatting (cherry picked from commit 2c87ec3)
…eoId
When playing a playlist via playerVars.list = [playlistId] we dont have a videoId available yet. Plus we don't need one, Youtube will start at the first video of the playlist by default.
By injecting an undefined videoId in the YT Player constructur, we end up with null value in the iframe url (
ps://www.youtube.com/embed/null?cc_load_policy=1&enablejsapi=1&controls=1&showinfo=0&rel=0&listType=playlist&list=PLxf07yK_HAvdwhW-L0X3uP5aMe6eEt50v) which is causing an Invalid Video Id error for consumers.