Skip to content

fix(cdk/menu): close sibling triggers when opening a menu #30894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mistrykaran91
Copy link
Contributor

@mistrykaran91 mistrykaran91 commented Apr 17, 2025

Currently, when any sibling menu is opened then it overlaps and in cases it freezes and makes the screen unresponsive. This fix will close any sibling menu if its open.

Fixes #30881

@mistrykaran91 mistrykaran91 requested a review from a team as a code owner April 17, 2025 08:40
@mistrykaran91 mistrykaran91 requested review from adolgachev and crisbeto and removed request for a team April 17, 2025 08:40
@mistrykaran91 mistrykaran91 force-pushed the fix/cdk-menu-screen-freeze-issue branch 7 times, most recently from 63bd6a1 to 269e23c Compare April 18, 2025 14:31
@mistrykaran91 mistrykaran91 force-pushed the fix/cdk-menu-screen-freeze-issue branch from 269e23c to f27f31b Compare May 2, 2025 04:33
@mistrykaran91 mistrykaran91 force-pushed the fix/cdk-menu-screen-freeze-issue branch from f27f31b to 863f43a Compare June 9, 2025 06:23
@mistrykaran91
Copy link
Contributor Author

@crisbeto @mmalerba : It will be helpful if this can be looked into :)

Currently, when any sibling menu is opened then it overlaps and in cases it makes the screen unresponsive. This fix will close any sibling menu if its open

Fixes angular#30881
@mistrykaran91 mistrykaran91 force-pushed the fix/cdk-menu-screen-freeze-issue branch from 863f43a to 74a14db Compare June 24, 2025 09:09
@mistrykaran91 mistrykaran91 requested a review from crisbeto June 24, 2025 09:21
@crisbeto crisbeto removed the request for review from adolgachev June 25, 2025 07:04
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 25, 2025
@crisbeto crisbeto merged commit 4230292 into angular:main Jun 25, 2025
28 checks passed
@crisbeto
Copy link
Member

The changes were merged into the following branches: main, 20.0.x

crisbeto pushed a commit that referenced this pull request Jun 25, 2025
Currently, when any sibling menu is opened then it overlaps and in cases it makes the screen unresponsive. This fix will close any sibling menu if its open

Fixes #30881

(cherry picked from commit 4230292)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/menu target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(cdk/menu): screen is freezing and becomes unresponsive when cdkContextMenuTriggerFor and cdkMenuTriggerFor is used together
2 participants