feat(menu): add animations #1685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
hansl
approved these changes
Nov 1, 2016
src/lib/menu/menu-item.html
Outdated
| <ng-content></ng-content> | ||
| <div class="md-menu-ripple" *ngIf="!disabled" md-ripple md-ripple-background-color="rgba(0,0,0,0)" | ||
| [md-ripple-trigger]="_getHostElement()"> | ||
| </div> No newline at end of file |
src/lib/menu/menu.scss
Outdated
| left: 0; | ||
| bottom: 0; | ||
| right: 0; | ||
| } |
kara
force-pushed
the
menu-ripple
branch
2 times, most recently
from
734a59c to
52a8841
Compare
Member
|
LGTM |
Contributor
Author
|
I think the animation timing messed up e2es. Fixing. |
kara
force-pushed
the
menu-ripple
branch
3 times, most recently
from
b6ebf18 to
db64a66
Compare
Contributor
Author
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds animations (including the ripple) to the menu.
r: @hansl