virtual-scroll: switch back to markForCheck since detectChanges
#12329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
added
pr: merge safe
target: patch
crisbeto
added
pr: lgtm
action: merge
jelbourn
reviewed
Jul 23, 2018
| @@ -315,7 +311,7 @@ export class CdkVirtualScrollViewport implements OnInit, OnDestroy { | |||
| this._isChangeDetectionPending = false; | |||
|
|
|||
| // Apply changes to Angular bindings. | |||
| this._ngZone.run(() => this._changeDetectorRef.detectChanges()); | |||
| this._ngZone.run(() => this._changeDetectorRef.markForCheck()); | |||
There was a problem hiding this comment.
Add a comment here that explains the context around using markForCheck so that someone else down the line doesn't try to switch to detectChanges again?
breaks viewports that are inside an `OnPush` component
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaks viewports that are inside an
OnPushcomponent.Fixes issue introduced by #12158