setting state.on to the right value after sending state changes to the bridge #38 #39

willie68 · 2021-04-13T10:19:05Z

THis is the simple solution. At the moment the response of the bridge will not be evaluated. (Maybe in the next step)

…e bridge amimof#38

adding color converting to lights and groups

amimof · 2021-04-20T13:13:58Z

@willie68 Thanks for contributing 👏 Please tell me when this is ready for review

willie68 · 2021-04-20T15:12:39Z

I think review can happen now.
I don't know why travis can't build this...

amimof · 2021-04-21T07:46:04Z

How about if Bri is set to 0, i guess the state.on would always be true in any case?

group.go

light.go

group.go

willie68 · 2021-04-21T09:18:59Z

Changed the comments, added comment on ConvertRGB, adding tests.
Beside the ConvertRGBToXy Test, all tests are failing on my side.
(Maybe because the Hue is not responding, because it's off. :-) )

amimof · 2021-04-22T07:51:46Z

@willie68 Did you read my latest comment about Bri being 0 and what the expected behavior would be?

willie68 · 2021-04-22T09:27:30Z

I just tested with bri = 0 and the light are not off, it's the lowest possible brightness but it's not off. So setting lights to bright 0 will not shut them down. That means state.on = true even if the bri is 0.

amimof · 2021-04-23T07:11:43Z

light_test.go

 	if err != nil {
 		t.Fatal(err)
 	}
+	assert.True(t, light.IsOn())


This line is why tests fails. It doesn't receive expected result. Can you have a look?

willie68 · 2021-04-23T08:56:21Z

Just missed a single light.State.On = true

willie68 added 3 commits April 13, 2021 12:17

setting state.on to the right value after sending state changes to th…

4ff3311

…e bridge amimof#38

adding set color to light

3afcf16

removing state.on bug on group, too

78fdfee

adding color converting to lights and groups