Skip to content

include exception for parser handling of file type: fixes unexpected keyword 'encoding' #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dirksavage88 wants to merge 1 commit into from
Closed

include exception for parser handling of file type: fixes unexpected keyword 'encoding' #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ament_cmake_core/cmake/core/package_xml_2_cmake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,19 @@ def main(argv=sys.argv[1:]):
description='Parse package.xml file and print CMake code defining '
'several variables',
)
parser.add_argument(
try:
parser.add_argument(
'package_xml',
type=argparse.FileType('r', encoding='utf-8'),
help='The path to a package.xml file',
)

except:
parser.add_argument(
'package_xml',
type=argparse.FileType('r'),
help='The path to a package.xml file',
)
parser.add_argument(
'outfile',
nargs='?',
Expand Down