Skip to content

Conversation

@cameron-martin
Copy link
Contributor

@cameron-martin cameron-martin commented Feb 26, 2021

This is a continuation of #152. I've fixed the remaining issues since the original PR has stalled and upgrading micromatch is important to us for security reasons.

Fixes #154.

@cameron-martin cameron-martin marked this pull request as ready for review February 26, 2021 17:06
@cameron-martin cameron-martin mentioned this pull request Feb 26, 2021
4 tasks
@cameron-martin
Copy link
Contributor Author

@amasad @stefanpenner Could you give some sort of indication that at some point you will review and merge this? Otherwise we'll have to go through the painful process of forking.

@mariomc
Copy link

mariomc commented Mar 12, 2021

Please give an heads-up once a resolution is found.
Either a new minor with a different dependency on minimist or a new major with the changes here introduced are essential.

Otherwise, everyone using this dependency is faced with a similar warning:
Screenshot 2021-03-12 at 16 19 11

@COScholl
Copy link
Collaborator

@amasad @stefanpenner Could you give some sort of indication that at some point you will review and merge this? Otherwise we'll have to go through the painful process of forking.

I am working on getting write access to merge necessary code for updating dependencies. I'll reach out once that happens.

@COScholl COScholl merged commit b09ec03 into amasad:master Jun 27, 2021
COScholl added a commit that referenced this pull request Jun 27, 2021
@cameron-martin
Copy link
Contributor Author

Thanks for merging this. I see that master fails because it is still trying to also run tests on circleci. I'm not sure how to disable this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade to v ^4.x.x of micromatch to avoid npm vulnerability 1490 in kind-of

4 participants