Skip to content

Conversation

@conartist6
Copy link

This is a potential alternative to #147 which does not require micromatch@4. That comes at the cost of introducing a dependency on the parse-glob package, which is not the same parser that micromatch uses internally.

@conartist6
Copy link
Author

The benefit of adding the dependency though is that the micromatch parser (which is actually the picomatch parser) is has some unusual structure to support certain implementation details of the library. The parse-glob parser exists only to provide a public parsing API, and is therefore also likely to be more stable from a semver perspective.

Since this code only targets the node environment the weight of the additional dependency would not seem to me to be a major downside. The only worry I really have is whether there might be minor discrepancies between the behaviors of the two parsers which could cause bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant