refactor: code review fixes and cleanup #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes side effects from module import by moving run_startup_checks() call to main(). Also removes duplicate logging config from server.py. Improves testability and enables library reuse scenarios.
Creates unified REGION_METADATA dict combining region descriptions and geographic locations. Eliminates maintenance drift from having the same 22 regions defined in multiple places.
Removes ~120 docstrings that simply restated test function names. Test names are descriptive enough to convey intent.
Adds filterwarnings to ignore false-positive RuntimeWarning from AsyncMock's internal coroutine machinery during garbage collection.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 90.40% 90.44% +0.03%
==========================================
Files 8 8
Lines 813 816 +3
==========================================
+ Hits 735 738 +3
Misses 78 78
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
run_startup_checks()now called frommain()instead of module import, improving testability and enabling library reuseREGION_METADATAdict replaces duplicate region definitions, preventing maintenance driftTest plan