fix: graceful shutdown, package rename, and CI improvements #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename from alexei-led.aws-mcp-server to aws-mcp so users can run: uvx aws-mcp Entry point also renamed to aws-mcp for consistency.
Use os._exit(0) instead of sys.exit(0) in signal handlers. sys.exit() raises SystemExit which gets caught by asyncio event loop, preventing clean shutdown.
- Simplify Dockerfile to install pre-built wheel - Build package once, reuse for Docker and PyPI - Merge CI jobs for faster execution - Update to latest GitHub Actions (artifact v5) - Ensure consistent versioning across package and Docker
- MCP configuration (Claude Code/Desktop) is now front and center - Removed standalone commands (useless without MCP context) - Added all environment variables verified from source code - USAGE.md now focused on tools/resources/prompts only - Links to README for setup instructions
The publish job downloads only the wheel artifact without checking out the repository. uv publish without arguments needs pyproject.toml, so pass dist/* explicitly to publish from artifacts alone.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 91.29% 91.29%
=======================================
Files 8 8
Lines 804 804
=======================================
Hits 734 734
Misses 70 70
🚀 New features to boost your workflow:
|
The Dockerfile expects a pre-built wheel from `uv build`. The
.dockerignore was excluding dist/, causing Docker builds to fail.
The pre-built wheel approach works for multi-arch because:
- aws-mcp wheel is pure Python (py3-none-any)
- pip downloads arch-specific deps (cryptography, pydantic-core) from PyPI
- Dockerfile uses --platform=${TARGETPLATFORM} for correct base image
Benefits over building inside Docker:
- Faster builds (no build tools needed in container)
- Correct versioning (setuptools_scm has git history)
- Smaller build context (~32KB wheel vs full source)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
aws-mcpfor simpleruvx aws-mcpusageChanges
Core
__main__.py)aws-mcp-servertoaws-mcpin pyproject.tomlCI/CD
uv publishto work without repository checkout (uv publish dist/*)Documentation
Test plan
uvx aws-mcpworks with new package name