Skip to content

Conversation

@Vizonex
Copy link
Contributor

@Vizonex Vizonex commented Nov 11, 2025

What do these changes do?

This change is mainly an example of one of 4 libraries mentioned for trying to cache pickles instead of using traditional text files #922 If I have been slow about it it might be due to the fact that my week has been a lot busier than I had anticipated luckily I had today off to start looking into this more.

Are there changes in behavior for the user?

Related issue number

fixes #922 This doesn't exactly fix it yet since there's still 3 more libraries left that need experimenting with but this is a start towards doing it. (Hence why this is a draft)

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 11, 2025
@Vizonex Vizonex marked this pull request as ready for review November 12, 2025 00:05
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 12, 2025

CodSpeed Performance Report

Merging #1270 will degrade performances by 21.34%

Comparing Vizonex:pickles (a3022f8) with master (c881394)

Summary

❌ 11 regressions
✅ 234 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iterate_multidict_items[ci-py] 267.1 µs 328.8 µs -18.76%
test_iterate_multidict_items[cs-py] 193.8 µs 246.4 µs -21.34%
test_items_view_equals[cs-py] 666.4 µs 733.4 µs -9.13%
test_items_view_is_disjoint[cs-py] 635 µs 698.2 µs -9.06%
test_items_view_less[ci-py] 336.5 µs 398.5 µs -15.56%
test_items_view_less[cs-py] 249.9 µs 307.6 µs -18.76%
test_items_view_less_or_equal[ci-py] 332.2 µs 393 µs -15.46%
test_items_view_less_or_equal[cs-py] 247.1 µs 304.7 µs -18.91%
test_items_view_or[ci-py] 1.2 ms 1.4 ms -9.62%
test_items_view_or[cs-py] 844.9 µs 968.4 µs -12.75%
test_items_view_sub[cs-py] 486.8 µs 547 µs -11%

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.85%. Comparing base (c881394) to head (a3022f8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1270   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          26       26           
  Lines        3507     3507           
  Branches      252      251    -1     
=======================================
  Hits         3502     3502           
  Misses          3        3           
  Partials        2        2           
Flag Coverage Δ
CI-GHA 99.85% <100.00%> (ø)
pytest 99.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TODO] Replace tests/gen_pickles.py with a pytest plugin

1 participant