-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Description
I found this issue on my laptop which is still running OSX 10.8, but also on someone else's laptop running 10.9.
The issue seems to be this line, where we assume unconditionally that ssl has the OP_NO_COMPRESSION attribute whenever we create a connection with verify_ssl=False. But according to the ssl docs, this attribute only exists if the version of libssl backing the ssl module is at least 1.0.0. But on both of these OSX machines the _ssl extension module is linking in /usr/lib/libssl.0.9.8.dylib, and consequently ssl.OP_NO_COMPRESSION does not exist.
There was already a workaround for this in the codebase fairly recently, but it got taken out when python3.3 support was dropped in this commit. (For the record I am seeing this problem on 3.4.3.)