Skip to content

[ fix #645 ] Irrelevant Data.Empty #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2022
Merged

[ fix #645 ] Irrelevant Data.Empty #1732

merged 3 commits into from
Mar 11, 2022

Conversation

gallais
Copy link
Member

@gallais gallais commented Mar 4, 2022

Shall I also rename Data.Erased to Data.Irrelevant? I remember people complaining that
it's not the correct name for it. Data.Erased should instead be:

record Erased (A : Set a) where
  field @0 erased : A

@MatthewDaggitt
Copy link
Contributor

Shall I also rename Data.Erased to Data.Irrelevant?

Sounds reasonable to me 👍

@MatthewDaggitt MatthewDaggitt added this to the v2.0 milestone Mar 6, 2022
MatthewDaggitt
MatthewDaggitt reviewed Mar 10, 2022
View reviewed changes
@MatthewDaggitt MatthewDaggitt merged commit 367e3d6 into agda:master Mar 11, 2022
@gallais gallais deleted the irrelevant-empty branch March 11, 2022 19:52
@andreasabel andreasabel mentioned this pull request Jul 24, 2023
Merged
@andreasabel andreasabel mentioned this pull request Aug 27, 2023
Merged
@andreasabel andreasabel mentioned this pull request Oct 12, 2023
Closed
@jamesmckinna jamesmckinna mentioned this pull request Jun 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewDaggitt MatthewDaggitt MatthewDaggitt left review comments

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gallais @MatthewDaggitt