-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: prevent form submission when required Select has more than 300 options and no selection #8280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
62cdb87
fix: prevent form submission when required Select has more than 300 o…
lucasweng 8f2dc84
fix: only block form submission if the validation behavior is native
lucasweng c21313a
fix: lint errors
lucasweng 89056dd
fix: prevent invalid form control error and native error popup for vi…
lucasweng ddb1e00
fix: prevent visually hidden text input from affecting keyboard navig…
lucasweng 2c4b1dc
refactor: use display: none instead of visually hidden to hide the input
lucasweng 401b82c
Merge branch 'main' into issues-8034
snowystinger 4cf2ea2
Merge remote-tracking branch 'upstream/main' into issues-8034
lucasweng cbf7149
Merge branch 'main' into issues-8034
snowystinger 5af0bd2
fix conflict where select would steal focus on invalid from previous …
snowystinger 9333aeb
Merge remote-tracking branch 'upstream/main' into issues-8034
lucasweng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ | |
*/ | ||
|
||
import {FocusableElement, RefObject} from '@react-types/shared'; | ||
import React, {JSX, ReactNode, useRef} from 'react'; | ||
import React, {InputHTMLAttributes, JSX, ReactNode, useRef} from 'react'; | ||
import {selectData} from './useSelect'; | ||
import {SelectState} from '@react-stately/select'; | ||
import {useFormReset} from '@react-aria/utils'; | ||
|
@@ -141,13 +141,38 @@ export function HiddenSelect<T>(props: HiddenSelectProps<T>): JSX.Element | null | |
</div> | ||
); | ||
} else if (name) { | ||
let data = selectData.get(state) || {}; | ||
let {validationBehavior} = data; | ||
|
||
let inputProps: InputHTMLAttributes<HTMLInputElement> = { | ||
type: 'hidden', | ||
autoComplete: selectProps.autoComplete, | ||
name, | ||
disabled: isDisabled, | ||
value: state.selectedKey ?? '' | ||
}; | ||
|
||
if (validationBehavior === 'native') { | ||
// Use a visually hidden <input type="text"> rather than <input type="hidden"> | ||
// so that an empty value blocks HTML form submission when the field is required. | ||
return ( | ||
<input | ||
{...containerProps} | ||
{...inputProps} | ||
type="text" | ||
tabIndex={-1} | ||
required={selectProps.required} | ||
onChange={() => {/** Ignore react warning. */}} | ||
onInvalid={(e) => { | ||
// Prevent native browser error popup from appearing. | ||
e.preventDefault(); | ||
triggerRef.current?.focus(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think useFormValidation should handle this. The trigger shouldn't necessarily be focused on invalid - the first invalid field in the form should be focused, which might not be the select. We may need to attach the |
||
}} /> | ||
); | ||
} | ||
|
||
return ( | ||
<input | ||
type="hidden" | ||
autoComplete={selectProps.autoComplete} | ||
name={name} | ||
disabled={isDisabled} | ||
value={state.selectedKey ?? ''} /> | ||
<input {...inputProps} /> | ||
); | ||
} | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.