Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Tweak update-dialog style #7636

Merged
JeffryBooher merged 4 commits into from
May 2, 2014
Merged

Tweak update-dialog style #7636

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9a7c06
Tweak update-dialog style
Apr 24, 2014
fb7ed90
Scrollbars fill the whole dialog
Apr 30, 2014
d17827e
Tweak about-dialog style
Apr 30, 2014
556df41
Code review changes
Apr 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/htmlContent/about-dialog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="modal-header">
<h1 class="dialog-title">{{Strings.ABOUT}}</h1>
</div>
<div class="modal-body">
<div class="modal-body no-padding">
<img class="about-icon" src="{{ABOUT_ICON}}">
<div class="about-text">
<h2>{{APP_NAME_ABOUT_BOX}}</h2>
Expand Down
2 changes: 1 addition & 1 deletion src/htmlContent/update-dialog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<div class="modal-header">
<h1 class="dialog-title">{{UPDATE_AVAILABLE_TITLE}}</h1>
</div>
<div class="modal-body">
<div class="modal-body no-padding">
<img class="update-icon" src="styles/images/update_large_icon.svg">
<div class="update-text">
<p class="dialog-message">{{UPDATE_MESSAGE}}</p>
Expand Down
15 changes: 9 additions & 6 deletions src/styles/brackets_patterns_override.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,12 +704,14 @@ a[href^="http"] {
}
.update-text {
// Icon is 120px, so we need at least that much left padding/margin to avoid overlap
margin: 0 10px 0 123px;
margin-left: 123px;

.update-info {
max-height: 200px;
overflow: auto;
padding-top: 20px;
max-height: 280px;
overflow: auto;

.update-info {
margin-right: 10px;
// Enable text selection
cursor: auto;
.user-select(text);
Expand Down Expand Up @@ -964,14 +966,15 @@ a[href^="http"] {
}
.about-text {
// Icon is 120px, so we need at least that much left padding/margin to avoid overlap
margin: 0 10px 0 123px;
margin-left: 123px;
Copy link
Member

@larz0 larz0 Apr 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it 130px so there's more spacing between the logo and text.

overflow: auto;

#about-build-number {
color: @tc-light-weight-quiet-text;
}
.about-info {
max-height: 300px;
overflow: auto;
margin-right: 10px;
}
.about-contributors {
min-height: 100px;
Expand Down