Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fix #5741: No Live Preview Error when launching Live Preview from an image #5808

Merged
couzteau merged 1 commit into from
Nov 4, 2013
Merged

Fix #5741: No Live Preview Error when launching Live Preview from an image #5808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/LiveDevelopment/LiveDevelopment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ define(function LiveDevelopment(require, exports, module) {
// After (1) the interstitial page loads, (2) then browser navigation
// to the base URL is completed, and (3) the agents finish loading
// gather related documents and finally set status to STATUS_ACTIVE.
var doc = _getCurrentDocument(); // TODO: probably wrong...
var doc = _liveDocument.doc;
Copy link
Member

@couzteau couzteau Nov 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the right thing to do. As indicated by the TODO in the old code attempting to get the current document will fail, that is return null if an image is displayed. However, liveDocument must always be set if live dev is up and running.

Copy link
Contributor Author

@marcelgerber marcelgerber Nov 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is set within this file, so that shouldn't be a problem.


if (doc) {
var status = STATUS_ACTIVE,
Expand Down