Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@marcelgerber
Copy link
Contributor

There were some changes to the english samples, so I translated it into german.
Sometimes it's a pretty literal translation, sometimes not - it isn't always easy as we miss some words.

For review: @ingorichter @pthiess @couzteau

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we translate this into german, too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would say yes.

@ghost ghost assigned ingorichter Oct 21, 2013
@marcelgerber
Copy link
Contributor Author

@ingorichter Have you taken a look on this?

ingorichter added a commit that referenced this pull request Oct 23, 2013
@ingorichter ingorichter merged commit 0f71dae into adobe:master Oct 23, 2013
@ingorichter
Copy link
Contributor

@SAplayer Danke!

@marcelgerber marcelgerber deleted the german-samples branch October 23, 2013 17:16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the belated drive by, but I think namhafter is not good German. I'd say "Ein entscheidender Unterschied" or "Ein wichtiger Unterschied"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it sound a little old fashioned i would choose "Ein entscheidender Unterschied"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed commit ae102ce, so I would like you to review. As soon as we're ready, I will create a PR for that.

Please take a look at this commit, too.

@marcelgerber
Copy link
Contributor Author

Sometimes it's a pretty literal translation, sometimes not - it isn't always easy as we miss some words.

Yes, maybe we should change something. But schneller Inline-Editor wasn't introduced by me, it was there before ;) (but we should keep changes in samples and strings.js in sync).

@pthiess
Copy link
Contributor

pthiess commented Oct 29, 2013

To be clear I'm not blaming anyone, except myself for not raising my feelings earlier just a little bit -:) I'm actually very appreciative to all your individual as well as generally all contributions which made it into the project.
Also I'm not an expert for translations and as such I also put this up for feedback.
@SAplayer if you have strong feelings either way you should feel empowered to propose changes for overall improvements. I like the fact that you push back on things which don't make sense to you and that you encourage us to focus on things you value. As a contributor you have noticeable impact on the overall work.
Thank you very much,

Best,
Peter Thiess

@marcelgerber
Copy link
Contributor Author

I just pushed commit ae102ce, so I would like you to review. As soon as we're ready, I will create a PR for that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants