Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

@WebsiteDeveloper
Copy link
Contributor

#4949

@redmunds because the issue is assigned to you.

@ghost ghost assigned redmunds Oct 4, 2013
@redmunds
Copy link
Contributor

This looks good. Since that if statement was removed, this code:

        var tagInfo,
            query,
            tokenType;

        this.editor = editor;

        tagInfo = HTMLUtils.getTagInfo(editor, editor.getCursorPos());
        query = null;
        tokenType = tagInfo.position.tokenType;

Should be cleaned up to:

        var tagInfo   = HTMLUtils.getTagInfo(editor, editor.getCursorPos()),
            query     = null,
            tokenType = tagInfo.position.tokenType;

        this.editor = editor;

@redmunds
Copy link
Contributor

@WebsiteDeveloper Reminder: just a small code cleanup change remaining.

@redmunds
Copy link
Contributor

Merging. No need to hold this up for a little code cleanup.

redmunds added a commit that referenced this pull request Oct 17, 2013
@redmunds redmunds merged commit 13239cc into adobe:master Oct 17, 2013
@WebsiteDeveloper
Copy link
Contributor Author

@redmunds sry i was away a few days, but i'm glad it is finally merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants