This repository was archived by the owner on Sep 6, 2021. It is now read-only.
[LiveHTML] Some domdiff cleanup #5065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes naming and parameter ordering more consistent
ghost
assigned
There was a problem hiding this comment.
Looks like you no longer need elementInserts, textInserts, textChanges, elementsWithTextChanges, or elementDeletes--those were all from before the last rewrite, I believe.
|
Great cleanup (and thank goodness for I'll merge this--my comments above can be addressed later. |
dangoor
added a commit
that referenced
this pull request
Sep 6, 2013
peterflynn
added a commit
that referenced
this pull request
Sep 6, 2013
…nting * origin/master: (275 commits) Change copyright to 2013 Change copyright to 2013 Comment tweaks. Renamed addPos/offsetPos to _addPos/_offsetPos since they're private. Fix test for new status with LiveHTML Delete strings-app.js and remove "Gettings started line" Get some recent fixes from upstream Updated by ALF automation. Add comments for `generateAttributeEdits` Flesh out the comments for SimpleDOM. Replace .children checks with .isElement() Remove a bunch of unused variables (from review #5065) Fixed quiet scrollbar based on @TomMalbran's feedback. Removed base64 PNGs as they're no longer required. Updated year. Fixed based on @TomMalbran's feedback. Updated by ALF automation. Removed linux scrollbar style. Cleaned up a bit. Updated link. Removed quiet scrollbar styles as they're all in brackets_scrollbars.less now. ... Conflicts: src/brackets.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a good bit of domdiff cleaner and more consistent.
to @njx