Fix sizing and scrolling issues from latest upstream-master

[jasonsanjose]

@njx Fixes #2655, #2523, #2521.

• Handle redraw event on the widget (from the host editor) and refresh inline instances of CodeMirror
• Consolidate sizeInlineWidgetToContents() calls into an update event listener. Whenever an inline editor update's it's display, we force a new height on the inline widget container

I'm also seeing #2657 fixed in my branch. But I'm not sure how my changes would have affected horizontal scrolling.

[njx]

FYI, #2657 still repros in this branch--you might have to resize the window narrower and then wider a few times to see it.

[njx]

Reviewing

[njx]

Since we're now calling this on every update of the inline editor, we should be careful that we're not doing any work we don't need to. I would hope this is a no-op if the height hasn't changed, but to be safe, could we guard this inside the if (changed) block?

[jasonsanjose]

fixed

[njx]

Review done. Looks good and seems to work--just the one comment.

[jasonsanjose]

@njx ready to review

[njx]

Actually--this should still (also) be in the if (changed), right?

[jasonsanjose]

Fixed

[njx]

Re-reviewed, still needs one tweak.

[njx]

Still not quite right, sorry :) -- this will make it so we bail (in the else below) if changed is false even if inlineWidget.info is defined, so we would skip executing the ensureVisible code (which we should only skip if inlineWidget.info is undefined).

[njx]

Just one more thing...

[jasonsanjose]

@njx Whoops. Thanks for pointing that out.

[njx]

Missing comma

[njx]

Fixed the last little bit. Merging.