Cleanup the Preferences IDs

[TomMalbran]

Lance Campbell just mentioned on the forums https://groups.google.com/forum/#!topic/brackets-dev/rYDR13sbhnk that the preferences seem to have several different IDs:

Example 1: "language/JSLintUtils"
Example 2: "com.adobe.brackets.Editor"
Example 3: "main"

I would suggest replacing all of them with "com.adobe.brackets." + module.id to best try to avoid any kind of namespace collision.

[pthiess]

Reviewed and assigned to @dangoor , I consider this a very useful and straight forward improvement - please advice.

[WebsiteDeveloper]

One thing i have to add, the naming of the preferences constant is somewhat inconsistent sometimes it is PREFERENCES_CLIENT_ID and in some files PREFERENCES_KEY i think we should also normalize those.

[dangoor]

@TomMalbran there have been a couple of pull requests merged for this. Do you think this issue is fully resolved?

[TomMalbran]

I believe it should be all done. But we might need a followup issue to remove all the handleClientIdChange in a few springs.

[dangoor]

OK, thanks for working on this. I've opened issue #3217 to clean up the migration code. I made a comment in there to think about this around sprint 25 and assigned the issue to me so that I'll spot it from time to time when looking at my assigned issues.