Skip to content
This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
7350e44
add support for Windows Areo Glass
JeffryBooher Nov 12, 2013
575f8d3
fix maximize for glass
JeffryBooher Dec 3, 2013
a0ec121
update gyp files
JeffryBooher Dec 3, 2013
e88d5f2
fix restore for glass
JeffryBooher Dec 3, 2013
d129ed8
document glass maximize work-around
JeffryBooher Dec 3, 2013
7094875
configurations and allow glass to be used at runtime
JeffryBooher Dec 3, 2013
5c86693
fix drawing issues
JeffryBooher Dec 4, 2013
18ba311
update titlebar with WM_SETTEXT
JeffryBooher Dec 4, 2013
09815d9
hover states on sys buttons
JeffryBooher Dec 4, 2013
53671ed
pressed states on sys buttons
JeffryBooher Dec 4, 2013
c01b0f3
hover states on menu items
JeffryBooher Dec 5, 2013
2d48e52
fix menu drawing shenanigans
JeffryBooher Dec 5, 2013
1c5fd75
optimize code a bit/documentation
JeffryBooher Dec 5, 2013
f6774a8
implement CDwmDLL class to load dwmapi.dll dynamically, if supported …
bchintx Dec 5, 2013
82e1826
miscelaneous cleanup, fixes and such
JeffryBooher Dec 6, 2013
ec141bd
a little closer on secondary windows
JeffryBooher Dec 6, 2013
3666ff8
rework secondary windows a bit
JeffryBooher Dec 6, 2013
f0734d6
cleanup code and fix compliation errors for other configs
JeffryBooher Dec 6, 2013
d2d4927
fixes menu drawing issue when maximized
JeffryBooher Dec 6, 2013
f92c8ea
merge with master
JeffryBooher Jan 6, 2014
50e6032
a few last minute fixes/updates
JeffryBooher Jan 6, 2014
83bf21e
fix window icon placement on xp
JeffryBooher Jan 6, 2014
b665e72
tweak system icon placement
JeffryBooher Jan 6, 2014
d84ef25
fixes XP menu drawing
JeffryBooher Jan 7, 2014
f556434
fix a few more XP (non-aero) drawing issues
JeffryBooher Jan 7, 2014
574d93a
fix aero full screeen menu drawing glitch
JeffryBooher Jan 8, 2014
b6869c1
make menu bar height dynamic based on content
JeffryBooher Jan 8, 2014
bca0097
fix virtual overrides to call base when not using aero
JeffryBooher Jan 9, 2014
c1b959d
fixed rte stack overflow due to recursion
JeffryBooher Jan 9, 2014
abde474
XP Icon Placement
JeffryBooher Jan 10, 2014
7bac7ad
fixes https://github.com/adobe/brackets/issues/6449
JeffryBooher Jan 10, 2014
0dad2ae
Change system icon gap to 1px on Aero
JeffryBooher Jan 10, 2014
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions appshell/appshell_extensions_win.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1175,16 +1175,17 @@ int32 getNewMenuPosition(CefRefPtr<CefBrowser> browser, const ExtensionString& p
int32 AddMenu(CefRefPtr<CefBrowser> browser, ExtensionString itemTitle, ExtensionString command,
ExtensionString position, ExtensionString relativeId)
{
HMENU mainMenu = GetMenu((HWND)getMenuParent(browser));
HWND mainWindow = (HWND)getMenuParent(browser);
HMENU mainMenu = GetMenu(mainWindow);
if (mainMenu == NULL) {
mainMenu = CreateMenu();
SetMenu((HWND)getMenuParent(browser), mainMenu);
SetMenu(mainWindow, mainMenu);
}

int32 tag = NativeMenuModel::getInstance(getMenuParent(browser)).getTag(command);
int32 tag = NativeMenuModel::getInstance(mainWindow).getTag(command);
if (tag == kTagNotFound) {
tag = NativeMenuModel::getInstance(getMenuParent(browser)).getOrCreateTag(command, ExtensionString());
NativeMenuModel::getInstance(getMenuParent(browser)).setOsItem(tag, (void*)mainMenu);
tag = NativeMenuModel::getInstance(mainWindow).getOrCreateTag(command, ExtensionString());
NativeMenuModel::getInstance(mainWindow).setOsItem(tag, (void*)mainMenu);
} else {
// menu is already there
return NO_ERROR;
Expand Down Expand Up @@ -1221,11 +1222,12 @@ int32 AddMenu(CefRefPtr<CefBrowser> browser, ExtensionString itemTitle, Extensio
}
else
{
int32 relativeTag = NativeMenuModel::getInstance(getMenuParent(browser)).getTag(relativeId);
int32 relativeTag = NativeMenuModel::getInstance(mainWindow).getTag(relativeId);
if (!InsertMenuItem(mainMenu, relativeTag, FALSE, &menuInfo)) {
return ConvertErrnoCode(GetLastError());
}
}
::SendMessage(mainWindow, WM_USER+1004, 0, 0);
return errCode;
}

Expand Down
Loading