Skip to content

Shrink non-FULL builds (SAMDs mostly) #10269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Apr 17, 2025

* Use 0 bytes for QSTR hash. Fixes #10151
* Update libgcc used on SAMD21 to 14.2. Reduces test build by over 100 bytes.
* Turn off 'd' typecode support on non-full builds.
dhalbert
dhalbert previously approved these changes Apr 17, 2025
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dhalbert
Copy link
Collaborator

TRRS trinkey build is failing.

@tannewt tannewt marked this pull request as ready for review April 21, 2025 18:17
@tannewt tannewt requested a review from dhalbert April 21, 2025 20:08
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trinket M0 is 184424 bytes here, tip of main is currently 185492, looks good! Also did some very simple smoke tests on Trinket M0.

@dhalbert dhalbert merged commit b3ff084 into adafruit:main Apr 21, 2025
615 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MICROPY_QSTR_BYTES_IN_HASH performance/size tradeoff
2 participants