Fix non-blocking query/mutation execution #35
+356
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified async query/mutation handling to properly support concurrent operations: - Replaced complex Task.Supervisor approach with simple Task.async - Added conditional support for OpentelemetryProcessPropagator.Task for proper tracing - Removed unnecessary QuerySupervisor module - Queries/mutations now execute asynchronously like subscriptions This allows multiple queries to run concurrently per connection, with fast queries completing before slow ones as expected by frontend transport layers. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Task.asyncinstead of complexTask.SupervisorapproachOpentelemetryProcessPropagator.Taskfor proper distributed tracingProblem
Previously, queries and mutations were blocking, allowing only one query in progress per connection. This was incorrect as each query should be able to be fired and asynchronously listen for its response, following a similar flow to subscriptions.
Solution
handle_query_or_mutationfunction to useTask.asyncfor non-blocking executionOpentelemetryProcessPropagator.Taskwhen available for proper tracing context propagationQuerySupervisormodule that added complexity without benefitTest Results
All tests pass, including the specific
non_blocking_query_test.exsthat verifies:This brings query/mutation handling in line with how subscriptions work and matches what frontend transport layers expect.
🤖 Generated with Claude Code