feat(spec): Add support for @oneOf directive
#1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cschiewek
force-pushed
the
cschiewek/@oneOf
branch
6 times, most recently
from
9d1a9f4 to
819d930
Compare
cschiewek
force-pushed
the
cschiewek/@oneOf
branch
from
819d930 to
4071e27
Compare
Comment on lines
+18
to
+19
| # Ignore input objects without schema nodes | ||
| defp process(%Argument{input_value: %{normalized: %Object{schema_node: nil}}} = node), do: node |
Contributor
There was a problem hiding this comment.
Is there a valid case where an input object wouldn't have a schema_node?
Member
Author
There was a problem hiding this comment.
No. If there's no schema_node, there's no __private__ field, so no chance that it has :one_of.
I'm not exactly sure when or why these are sometimes nil, but ignoring nodes with a schema_node is pretty common in phases (one example).
michaelcaterisano
approved these changes
Nov 5, 2025
Contributor
michaelcaterisano
left a comment
michaelcaterisano
left a comment
There was a problem hiding this comment.
Thanks for adding this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
@oneOfschema directive that was officially added to the spec in September.It adds:
It also updates both pipeline functions to include the 2 new phases.