Fix repairwheel on linux #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting rpath to @loader_path / $ORIGIN, breaks the wheels after repair step because the dependencies aren't copied to pywhispercpp.libs and rpath is set to $ORIGN/pywhipsercpp.libs. This is how the readelf of _pywhispercpp.cpython-312-aarch64-linux-gnu.so looks like on linux for a working wheel: 0x000000000000000f (RPATH) Library rpath: [$ORIGIN/pywhispercpp.libs] 0x0000000000000001 (NEEDED) Shared library: [libwhisper-40042964.so.1.7.1] 0x0000000000000001 (NEEDED) Shared library: [libstdc++-3f0d3c8a.so.6.0.33] 0x0000000000000001 (NEEDED) Shared library: [libgcc_s-1a8c3655.so.1] 0x0000000000000001 (NEEDED) Shared library: [libc-07406008.so.6] 0x0000000000000001 (NEEDED) Shared library: [ld-linux-aarch64.so.1] On a broken wheel the libwhisper is not copied to pywhispercpp.libs.
Owner
|
Yeah, that makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package was failing on unbuntu because of the change I've made to support editable mode, so I've made the change conditional and run only when pip install -e . is executed.
This showed another issue though. On linux our wheels contains the libwhipser.so twice, and one is redundant, we should fix that, I will create a new pull request once I figure out how.
To give you more info setting rpath to $ORIGIN, breaks the wheels after repair step because the dependencies aren't copied to pywhispercpp.libs and rpath is corrected to $ORIGN/pywhipsercpp.libs.
This is how the readelf of _pywhispercpp.cpython-312-aarch64-linux-gnu.so looks like on linux for a working wheel:
On a broken wheel the libwhisper is not copied to pywhispercpp.libs, and stays as [libwhisper.so.1] here is the output:
This was build on ubuntu and the libc* where for some reason included in the wheel, I hope it won't happen when build on manylinux image.