Skip to content

fix: compile to fail when using DefaultSleeper with no features enabled #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix: compile to fail when using DefaultSleeper with no features enabled #136

merged 2 commits into from
Aug 30, 2024

Conversation

@bdbai
Copy link
Contributor

@bdbai bdbai commented Aug 30, 2024 •
edited by Xuanwo
Loading

  • Makes compilation to fail when using DefaultSleeper with no features enabled.
    • Should not panic as it is a valid Sleeper is guaranteed at compile time.
  • docs to instruct users to enable a feature or provide custom Sleeper.

Close #128

Xuanwo
Xuanwo approved these changes Aug 30, 2024
View reviewed changes
Copy link
Owner

@Xuanwo Xuanwo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I love this idea!

@Xuanwo Xuanwo merged commit 7237d04 into Xuanwo:main Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Panicking after upgrade

2 participants

@bdbai @Xuanwo