Skip to content

Restrict "Default Post Format" Options to Formats Supported by the Active Theme #9059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

sahil-gidwani
Copy link

This PR updates the options-writing.php admin screen to ensure that the "Default Post Format" dropdown only displays post formats explicitly supported by the currently active theme. Previously, this dropdown listed all core post formats, regardless of whether the theme declared support via add_theme_support( 'post-formats', [...] ).

This behavior led to possible misconfiguration, user confusion, and inconsistent behavior between the settings screen and the post editor (which already hides unsupported formats).

Previous Logic

The dropdown was populated using:

$post_formats = get_post_format_strings();
unset( $post_formats['standard'] );

This included all formats regardless of theme support.

New Logic

Replaced with:

$supported_formats = get_theme_support( 'post-formats' );

if ( is_array( $supported_formats ) && isset( $supported_formats[0] ) ) {
    $post_formats = array_intersect_key( get_post_format_strings(), array_flip( $supported_formats[0] ) );
} else {
    $post_formats = array();
}

This ensures only the intersection of supported formats and registered format strings is used. The standard format remains available separately, as it is treated as the fallback/default.

Why This Matters

  • Prevents the admin UI from offering unsupported options.
  • Aligns admin settings with front-end and post editor behavior.
  • Avoids storing invalid default values in default_post_format which have no effect on post rendering.
  • Reduces user confusion by not listing formats that won’t have any visible impact.

Edge Cases Handled

  • If the theme supports no formats, only the standard option is shown.
  • If the theme supports all formats, the dropdown behavior remains unchanged.
  • Backward compatibility is preserved, as the underlying storage and post format API remains the same.

Trac Link: https://core.trac.wordpress.org/ticket/43613

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sahilgidwani.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant