Add filter for post statuses in quickedit - Refreshing 36237.patch #9041
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refreshing and Improving 36237.patch
I've code reviewed it and compared to the original version, there was a little difference on the conditionals (adding Private status type too early).
I am not sure if this was implemented by the original author on purpose @kakomap because there doesn't seem to be an explanation on this.
Apart from this, everything looks good, a nice DRY refactor, meant to include the filter accordingly.
I will be posting a test to this refresh
Automated could be done through Playwright. But I would leave this for further iterations. If anyone wants to add this feel free.
Trac ticket: https://core.trac.wordpress.org/ticket/36237
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.