Closed
Description
#2702 exposes functionalities of ExpressionRunner
to Binaryen and C API. I find most usages there is about precomputing certain expression, and we have PrecomputeExpressionRunner
for that. But after #2702 some functionalities of PrecomputeExpressionRunner
are duplicated in ExpressionRunner
to make them exposed to Binaryen and C API, and I'm not very sure what the difference between ExpressionRunner
and PrecomputeExpressionRunner
is at this point.
So I'm not sure the functionalities of ExpressionRunner
class hierarchy is very well defined now. Can't Binaryen and C API make use of PrecomputeExpressionRunner
instead, if the main purpose of that is precomputing?
I might be mistaken, so please advise me if so :)
Metadata
Metadata
Assignees
Labels
No labels