Skip to content

Conversation

@D1firehail
Copy link
Contributor

@D1firehail D1firehail commented Feb 24, 2023

What did you fix?

  • Changed Scrollbar Colour
    • Dimon thought the new settings from Various features related to reward choice, some other fixes #263 were somewhat concealed due to the settings menu scrollbar blending in with the rest of the window. I think this colour change makes it sufficiently obvious without being too distracting
    • If anyone has a better idea (or colour), I'm open to suggestions
  • ThemeAdjuster changes
    • Add import/export functionality
    • Add some tooltips
    • Add basic instructions below image
    • Images are immediately shown on load

Reproduction steps

Scrollbar colour

  1. Look at any window with a scrollbar

ThemeAdjuster export

  1. Open Theme Adjuster
  2. Adjust filters as desired, or leave them be
  3. Click export button
  4. Copy the contents of the textbox wherever you want

ThemeAdjuster import

  1. Open Theme Adjuster
  2. Paste an export into the textbox (or from other sources, as long as it has all required entries)
  3. Click import button
  4. See your custom filter get set to the imported one
    • Invalid or incomplete import attempt should throw an error and change none of the settings

ThemeAdjuster image load

  1. Load image using either of the relevant buttons
  2. See if image showed up
  3. If image didn't show up, check if the image existed and if debug.log contains any errors

Other ThemeAdjuser Changes

  1. Just look at ThemeAdjuser, maybe hover your mouse over a few elements

Evidence/screenshot/link to line

image

Considerations

  • Does this contain a new dependency? [No]
  • Does this introduce opinionated data formatting or manual data entry? [No]
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? [No]
  • Have I run the linter? [No]
  • Is is a bug fix, feature request, or enhancement? [Feature/Enhancement]

…, ThemeAdjuster instructions, ThemeAdjuster show image on load
Copy link
Member

@dimon222 dimon222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimon222 dimon222 merged commit 75c8eff into WFCD:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants