Skip to content

Correct file sharing for exFAT partitions on macOS (case 1253812) #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Correct file sharing for exFAT partitions on macOS (case 1253812) #1307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions mono/metadata/w32file-unix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1794,14 +1794,15 @@ static mode_t convert_perms(guint32 sharemode)
static gboolean already_shared(gboolean file_alread_shared, ino_t inode)
{
#if HOST_DARWIN
/* On macOS and FAT32 partitions, we will sometimes get this inode value
* for more than one file. It means the file is empty (FILENO_EMPTY is
* defined in an internal header). When this happens, the hash table of
* file shares becomes corrupt, since more then one file has the same
* inode. Instead, let's assume it is always fine to share empty files.
* (Unity case 950616).
/* On macOS and FAT32 partitions, we will sometimes get an inode value
* of 999999999 (or 1 on exFAT partitions) for more than one file. It
* means the file is empty (FILENO_EMPTY is defined in an internal
* header). When this happens, the hash table of file shares becomes
* corrupt, since more then one file has the same inode. Instead, let's
* assume it is always fine to share empty files.
* (Unity case 950616 or case 1253812).
*/
return file_alread_shared && inode != 999999999;
return file_alread_shared && inode != 999999999 && inode != 1;
#else
return file_alread_shared;
#endif
Expand Down