Skip to content

chore: use import extensions in all packages (except docs) #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 8, 2024

Conversation

YousefED
Copy link
Collaborator

Closes #952

Copy link

vercel bot commented Jul 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Oct 8, 2024 8:36am
blocknote-website ✅ Ready (Inspect) Visit Preview Oct 8, 2024 8:36am

Copy link
Collaborator

@matthewlipski matthewlipski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is causing issues with the website, I assume it's a NextJS thing. Since the issue that this PR fixes only happens in public packages, I suggest we scope the .js extensions to only the public packages.

@YousefED
Copy link
Collaborator Author

YousefED commented Aug 6, 2024

Blocked by vercel/next.js#59744

@matthewlipski
Copy link
Collaborator

Blocked by vercel/next.js#59744

Isn't my suggestion still relevant though? SInce this is a NextJS issue and we only really need this in packages that are on npm. Or are there other problems with that?

@YousefED
Copy link
Collaborator Author

YousefED commented Aug 7, 2024

Blocked by vercel/next.js#59744

Isn't my suggestion still relevant though? SInce this is a NextJS issue and we only really need this in packages that are on npm. Or are there other problems with that?

Good point, the issue is that the examples span both the playground and the website. So I thought it wouldn't be possible. However, might be wrong, maybe I can use the "old style" in the examples as well. will investigate

@YousefED YousefED changed the title use import extensions in all packages (except docs) chore: use import extensions in all packages (except docs) Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import from BlockNote packages when using NodeNext for moduleResolution.
2 participants