-
-
Notifications
You must be signed in to change notification settings - Fork 558
chore: use import extensions in all packages (except docs) #956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this is causing issues with the website, I assume it's a NextJS thing. Since the issue that this PR fixes only happens in public packages, I suggest we scope the .js
extensions to only the public packages.
Blocked by vercel/next.js#59744 |
Isn't my suggestion still relevant though? SInce this is a NextJS issue and we only really need this in packages that are on npm. Or are there other problems with that? |
Good point, the issue is that the examples span both the playground and the website. So I thought it wouldn't be possible. However, might be wrong, maybe I can use the "old style" in the examples as well. will investigate |
Closes #952