Skip to content

fix: Custom inline content crash #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

conr
Copy link
Contributor

@conr conr commented May 31, 2024

Fixes #750

Before

image

After

image

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Jun 3, 2024 11:30am
blocknote-website ✅ Ready (Inspect) Visit Preview Jun 3, 2024 11:30am

Copy link

vercel bot commented May 31, 2024

@conr is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@conr conr marked this pull request as ready for review May 31, 2024 12:15
@YousefED
Copy link
Collaborator

YousefED commented Jun 3, 2024

Thanks @conr. This looks like a good temporary fix, but I still want to figure out the root cause (why is contentComponent undefined). If the CI passes I'd be happy to merge this regardless

@conr
Copy link
Contributor Author

conr commented Jun 6, 2024

@YousefED That's very fair!

Looks like CI is passing now

Copy link

@Dhruvagwal Dhruvagwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to be woking for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read properties of undefined (reading 'renderToElement')
4 participants