fix: Key inputs in blocks without content #730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves how keystrokes are handled in non-editable blocks like images, so that more edge cases are covered (including special characters like ś and Enter).
A more robust approach might be to filter out transactions in which a no content block is selected before, and replaced with a paragraph block after (will likely need additional filtering e.g. to not filter out
updateBlock
calls). However, I think the current implementation gets us 90% of the way there with much less complexity so I don't think it's worth looking into.TODO: We should merge the
releases
branch into main first