chore: Mantine update #479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Dec 15, 2023
YousefED
reviewed
Jan 3, 2024
package-lock.json
Outdated
| @@ -27,7 +27,7 @@ | |||
| "dependencies": { | |||
| "@blocknote/core": "^0.10.1", | |||
| "@blocknote/react": "^0.10.1", | |||
| "@mantine/core": "^5.6.1", | |||
| "@mantine/core": "^7.3.1", | |||
There was a problem hiding this comment.
todo: @YousefED check file
| className={classes.root} | ||
| sx={(theme) => { | ||
| className={"bn-color-icon"} | ||
| data-background-color={backgroundColor} |
There was a problem hiding this comment.
tbd; classname or data attribute?
packages/react/src/components/TableHandles/TableHandleMenu/TableHandleMenu.tsx
Outdated
Show resolved
Hide resolved
YousefED
requested changes
Jan 4, 2024
packages/react/src/components/TableHandles/DefaultTableHandle.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/SideMenu/DragHandleMenu/DragHandleMenu.tsx
Outdated
Show resolved
Hide resolved
YousefED
reviewed
Jan 6, 2024
YousefED
reviewed
Jan 6, 2024
…specificity issues caused by prev commit)
* Replaced Tippy with Floating UI * Fixed minor bugs and styling inconsistencies * try fix lock * Implemented PR feedback * update package lock * fix package lock * fix tests --------- Co-authored-by: yousefed <[email protected]>
YousefED
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Mantine to the newest version. The way themes are defined and applied has changed drastically since v7, and now uses CSS variables to store theming data instead of emotion. Currently, the API used to provide a theme is the same, but the theme is now converted into CSS variables instead of being passed as a
MantineThemeOverride. Some styling may be slightly different after moving to CSS, but these changes are small and should be easily fixable.NOTE: This PR breaks styling for tooltips, as they are rendered outside the
.bn-containerelement due to the current implementation, which uses Tippy. #501 fixes the issue and converts them to Mantine Tooltip components, causing the tooltips to be rendered as a sibling of the target element. So recommend merging that PR before this one.closes #383