Skip to content

fix: Made block type dropdown items apply type to all selected blocks #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: Made block type dropdown items apply type to all selected blocks #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/react/src/FormattingToolbar/components/DefaultDropdowns/BlockTypeDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
import { ToolbarDropdown } from "../../../SharedComponents/Toolbar/components/ToolbarDropdown";
import { ToolbarDropdownItemProps } from "../../../SharedComponents/Toolbar/components/ToolbarDropdownItem";
import { useEditorChange } from "../../../hooks/useEditorChange";
import { useSelectedBlocks } from "../../../hooks/useSelectedBlocks";

export type BlockTypeDropdownItem = {
name: string;
Expand Down Expand Up @@ -82,6 +83,8 @@ export const BlockTypeDropdown = <BSchema extends BlockSchema>(props: {
editor: BlockNoteEditor<BSchema>;
items?: BlockTypeDropdownItem[];
}) => {
const selectedBlocks = useSelectedBlocks(props.editor);

const [block, setBlock] = useState(
props.editor.getTextCursorPosition().block
);
Expand Down Expand Up @@ -123,10 +126,13 @@ export const BlockTypeDropdown = <BSchema extends BlockSchema>(props: {
const fullItems: ToolbarDropdownItemProps[] = useMemo(() => {
const onClick = (item: BlockTypeDropdownItem) => {
props.editor.focus();
props.editor.updateBlock(block, {
type: item.type,
props: item.props,
} as PartialBlock<BlockSchema>);

for (const block of selectedBlocks) {
props.editor.updateBlock(block, {
type: item.type,
props: item.props,
} as PartialBlock<BlockSchema>);
}
};

return filteredItems.map((item) => ({
Expand All @@ -135,7 +141,7 @@ export const BlockTypeDropdown = <BSchema extends BlockSchema>(props: {
onClick: () => onClick(item),
isSelected: item.isSelected(block as Block<BlockSchema>),
}));
}, [block, filteredItems, props.editor]);
}, [block, filteredItems, props.editor, selectedBlocks]);

useEditorChange(props.editor, () => {
setBlock(props.editor.getTextCursorPosition().block);
Expand Down