fix: Boolean/number props not getting parsed correctly #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Oct 4, 2023
Collaborator
YousefED
left a comment
YousefED
left a comment
There was a problem hiding this comment.
nice. I think it's smart to add tests for this as this is core functionality
YousefED
reviewed
Oct 9, 2023
YousefED
approved these changes
Oct 11, 2023
Collaborator
YousefED
left a comment
YousefED
left a comment
There was a problem hiding this comment.
nice that you added the test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last release made block props able to be booleans or numbers, not just strings. While the type definitions for this are all correct, there is an issue when parsing block props. All props are rendered to HTML attributes, so they must be converted to strings. This means when parsing them, we must also figure out whether to parse they should actually be booleans or numbers, which we weren't doing before. E.g. copy/pasting an image would cause the second image's
widthprop to be a string instead of a number.