Skip to content

fix: custom blocks may error when it is re-created #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: custom blocks may error when it is re-created #336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/react/src/ReactBlockSpec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,14 @@ export function createReactBlockSpec<
// Gets position of the node
const pos =
typeof props.getPos === "function" ? props.getPos() : undefined;

// workaround race condition when re-creating BlockNote from database:
// if the position of a node could not be found in a tiptap block, then
// the node isn't ready to be rendered
if (!pos) {
return <></>
}

// Gets TipTap editor instance
const tipTapEditor = editor._tiptapEditor;
// Gets parent blockContainer node
Expand Down