fix: placeholder defined in code instead of css #188
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
achrefBoukhili
force-pushed
the
fix-placeholder-from-code
branch
from
5a180c6 to
938425f
Compare
There was a problem hiding this comment.
Thanks for your contribution! I'm not sure it makes sense to merge these changes at the moment though, since we're still not set on how we want to implement default styling for BlockNote. Right now we're ok with using CSS modules, though I think this might change. We'll probably revisit this when we're sorting out localization for the whole editor, including menus. @YousefED Thoughts?
| translation: { | ||
| placeholder: "Geben Sie Text ein oder geben Sie '/' für Befehle ein", | ||
| heading: "Überschrift", | ||
| list: "Aufführen", |
There was a problem hiding this comment.
Not sure some of the translations are 100% consistent
| @@ -27,11 +27,11 @@ NESTED BLOCKS | |||
| margin-left: 1.5em; | |||
| } | |||
|
|
|||
| .blockGroup .blockGroup > .blockOuter { | |||
There was a problem hiding this comment.
I think it's better to keep the formatting as it was. Admittedly the CSS isn't very readable at the moment, but it would make it much easier to keep track of the more important changes in the PR.
| it: { | ||
| translation: { | ||
| placeholder: "Inserisci il testo o digita '/' per i comandi", | ||
| heading: "intestazione", |
There was a problem hiding this comment.
Should be capitalized
|
This is great @achrefBoukhili! My thoughts:
Let me know what you think! |
|
@YousefED thanks a lot for the feedback and all what you said it makes a sense I think. |
|
Closing this. It's now possible to change the placeholders, although this still needs to be documented. We'll also add support for i18n soon |
No description provided.