refactor: reuse toolbar types and extract mantine context #1440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
components
andBlockNoteView
file for mantine / ariakit / shadcn to cleanup a bitmantine/src/components.tsx
) we actually pass the sameToolbar
(andToolbarButton
) as the different components.These changes were extracted from the Comments PR, so that it's easy for Nick to continue on this work when working on tables
To discuss
does it still make sense to have a separate
FormattingToolbar
andLinkToolbar
?Pro:
Con:
We could also always use the generic component. And optionally, also pass in a parameter with the "location / usage" (not sure about right naming). e.g., instead of:
we do: